calcom / cal.com

Scheduling infrastructure for absolutely everyone.
https://cal.com
Other
31.41k stars 7.6k forks source link

[CAL-3888] Column view consistently ignores times blocked by connected calendars and shows full availability #14314

Open EduNetEurope opened 5 months ago

EduNetEurope commented 5 months ago

The monthly and weekly views accurately reflect availability based on connected calendars consistently. The column view. however, sometimes erroneously allows users to select and book times that should be marked as unavailable. It looks like it ignores times blocked by the connected calendars.

image image image

It consistently happens when we load the public booking page and switch from weekly view to column view or set column view as the standard view. When we use the arrows in column view to select another week, the availabities get corrected and are displayed as in the other two views. Going to another view and returning to the column view, reproduces the bug.

CAL-3888

dosubot[bot] commented 5 months ago

Hello @EduNetEurope! Great to see you here again. Hope you're doing well.

Based on the information you've provided, it seems like the issue you're experiencing is similar to a previously closed issue titled Appearing available when not actually available. This issue was resolved by a pull request: logic for determining months between dates improved on March 10, 2023. However, it's possible that the fix didn't cover all edge cases, or a regression might have occurred since then.

The inconsistency you're observing could be due to the way the application handles time zones, slot intervals, and booking statuses. These factors are crucial in determining the availability of slots, and any inconsistencies in their handling across different views could lead to the issue you're experiencing. You can find more details about this in the getSchedule.test.ts file.

In the cal.com codebase, the rendering of the column view is handled by the SchedulerColumns component. This component is used within the Calendar component to display both events and empty cells across the days in the calendar view. You can find the implementation of this in the Calendar.tsx file.

Unfortunately, I couldn't find any known bugs or issues in the SchedulerColumns component that could cause the discrepancy you're experiencing. It's possible that the issue lies elsewhere in the codebase or that it's a result of a combination of factors.

If you could provide more information about the specific circumstances under which the issue occurs, it would be helpful in narrowing down the potential causes. For example, does the issue occur with all types of events (e.g., all-day events, events spanning multiple days, etc.)? Does it occur in all time zones, or only specific ones? Any additional details you can provide would be greatly appreciated.

Sources

#### About Dosu This response is meant to be useful and save you time. It is **not meant to be a precise solution**, but rather a starting point for your own research. Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant. If you want to continue the conversation, start your reply with @dosu-bot.
milospuac commented 5 months ago

@emrysal @CarinaWolli can you look into this one?

EduNetEurope commented 4 months ago

The problem persists unfortunately.

CarinaWolli commented 4 months ago

I can't reproduce that on my account. Could you send us your username? Either here or to support@cal.com and link this issue

EduNetEurope commented 4 months ago

Great to see that @ciaranha has added a "High priority" label. @CarinaWolli Any updates?

CarinaWolli commented 4 months ago

@EduNetEurope we are not able to reproduce this, could you reach out to support to let us know your username? And please link this issue

EduNetEurope commented 4 months ago

@EduNetEurope we are not able to reproduce this, could you reach out to support to let us know your username? And please link this issue

Hello @CarinaWolli, I reached out to you on 29 April (15:51 CET) per email as you asked me. We use the self-hosted version.

CarinaWolli commented 4 months ago

Hello @CarinaWolli, I reached out to you on 29 April (15:51 CET) per email as you asked me. We use the self-hosted version.

We can't reproduce that issue on app.cal.com, could you provide more information on how we can reproduce that issue?

EduNetEurope commented 4 months ago

I have set daily working hours in "Availability". Several subcalendars of a Google Calendar are checked for conflicts to prevent double bookings. Column view ignores all events in all subcalendars and presents the availability according to the daily working hours.

We cannot activate column view because it would allow double bookings.

EduNetEurope commented 4 months ago

We can't reproduce that issue on app.cal.com, could you provide more information on how we can reproduce that issue?

Hello @CarinaWolli, I have just activated column view on my booking page and emailed you the link. I will deactivate column view again in a few hours. Thanks for having a look.

EduNetEurope commented 4 months ago

So this is the situation: I emailed the link to our booking page. Ewa confirmed the issue.

Since we are free self-hosters, they don't offer any support. We use cal.com provided by Cloudron.

Is there anyone out there who can help since the issue seems to appear only in the self-hosted version?

EduNetEurope commented 3 months ago

So good to see it was added to the v4.2 milestone. When the calendar view is opened first, all availabilities are displayed. After refreshing the browser while keeping the URL the same, blocked times disappear.