search

calcom / cal.com

Scheduling infrastructure for absolutely everyone.
https://cal.com
Other
30.26k stars 7.2k forks source link

ICS Feed incorrectly reports recurring events #14641

Open rgabbo opened 3 months ago

rgabbo commented 3 months ago

Issue Summary

I'm using the ICS Feed app to sync with my calendar but I noticed recurring event are incorrectly shifted of one day. For example in the screenshot provided I have a recurring event on monday that on cal.com is reported to be on tuesday.

Steps to Reproduce

  1. add ics feed as calendar provided https://ics.teamup.com/feed/ks4zmyg42imc8dhm3j/0.ics

Any other relevant information. For example, why do you consider this a bug and what did you expect to happen instead?

Actual Results

Expected Results

Evidence

Immagine

dosubot[bot] commented 3 months ago

The issue with recurring events being shifted by one day in the ICS Feed app likely stems from how time zones or daylight saving time adjustments are handled. This could be due to incorrect time zone data, improper handling of daylight saving time changes, or errors in time zone conversions, especially in the context of recurring events.

The @calcom/ics-feed package includes logic to adjust event times based on time zones, which is crucial for recurring events. It's important to ensure that time zone information is correctly applied and that any conversions accurately account for daylight saving time. The package attempts to handle time zones by adding a vtimezone component if missing, which is vital for the correct interpretation of recurring events.

There are also known issues with certain time zones being problematic due to daylight saving time adjustments or other calculations. The package identifies these in the isProblematicTimezone function, which could be contributing to the problem if your events fall into these categories.

To address the issue, verify the time zone settings of your calendar and events, ensuring that vtimezone components are correctly defined and match the intended time zones. This step is essential for the accurate generation of recurring event occurrences and their correct display on the calendar.

Sources

#### About Dosu This response is meant to be useful and save you time. It is **not meant to be a precise solution**, but rather a starting point for your own research. Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant. If you want to continue the conversation, start your reply with @dosu-bot.
PeerRich commented 2 months ago

the ICS feed app has a lot of issues that we are currently investigating