calcom / cal.com

Scheduling infrastructure for absolutely everyone.
https://cal.com
Other
31.7k stars 7.71k forks source link

ICS feed event import time zone fail, resulting in double bookings #14664

Open Vili opened 5 months ago

Vili commented 5 months ago

Issue Summary

On Cal.com, the ICS feed app for importing events for the purposes of checking conflicts fails to correctly recognize imported events' time zones. As a result, users can make bookings at times that are actually busy.

Steps to Reproduce

  1. In an Outlook calendar, added two events two hours apart, at 10am Helsinki time and at 10am London time.
  2. Published the calendar as an ICS feed.
  3. In Cal.com, under My Settings / Calendars / Check for conflicts, clicked +Add.
  4. Added the ICS feed app with the ICS feed URL obtained from Outlook.

Actual Results

In Cal.com, navigated to Event types / Preview / Need help? to bring up the Troubleshoot view. Observed that the 10am Helsinki time event and the 10am London time event were displayed on top of each other, at 10am system local time.

Expected Results

The 10am Helsinki time event should show up in the Troubleshoot view at 10am Helsinki time and the 10am London time event should show up at 10am London time, ie. two hours apart. It should not be possible to book appointments on Cal.com at either of these times.

Technical details

Tested on Safari 16.6.

Evidence

Compare the two events scheduled two hours apart on Tuesday 30th morning between an Outlook calendar (original event source), MacOS Calendar (Outlook calendar events added via both an Office365 subscription and an ICS feed subscription; the events show up correctly at two hours apart), and the Cal.com Troubleshoot view (Outlook calendar events added via ICS feed subscription; events show up incorrectly at the same time).

Outlook calendar screenshot MacOS Calendar screenshot Cal com troubleshoot screenshot
dosubot[bot] commented 5 months ago

The issue you're encountering with the ICS feed app on Cal.com, where events from different time zones are incorrectly displayed at the same time, seems to stem from how the app processes time zones. This can lead to events like those set for 10am in Helsinki and London being shown simultaneously, potentially causing double bookings.

To address this, the app's time zone handling needs enhancement. This involves ensuring accurate time zone interpretation for events, improving the handling of VTIMEZONE components in ICS feeds, and updating the app to correctly work with time zone data. Additionally, testing with ICS feeds from various sources and time zones will be crucial for identifying and fixing the underlying issues.

There have been similar issues reported and resolved in the past, which suggests that the development team is aware of the complexities involved with time zone handling in calendar events. For a more immediate resolution, reviewing the app's current approach to time zone management and ensuring all dependencies are up-to-date could provide some relief.

If the problem persists, providing more detailed information about the steps you're taking and any specific error messages could help in diagnosing and resolving the issue more effectively.

Sources

#### About Dosu This response is meant to be useful and save you time. It is **not meant to be a precise solution**, but rather a starting point for your own research. Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant. If you want to continue the conversation, start your reply with @dosu-bot.
carsonwlee commented 5 months ago

Same issue for me