calcom / cal.com

Scheduling infrastructure for absolutely everyone.
https://cal.com
Other
30.07k stars 7.11k forks source link

[CAL-3914] Patch request to confirm a booking doesn't run the business logic #15389

Open martinfeuillet opened 1 month ago

martinfeuillet commented 1 month ago

Is your proposal related to a problem?

When we do a patch request to confirm a pending booking, all the business logic aren't triggered. I explain : There is a problem when the booking needs to be confirmed. When it's this scenario, i do a patch on the booking by doing : {{baseUrl}}/bookings/:id and changing the status from pending to accepted, a link is not generated, and i also don't have any mail that are generated to warn the user and the owner of the booking that this one is accepted.

Describe the solution you'd like

I would like to have a google meet link and mails sent to the user and the owner of the meeting, exactly as when we book a simple booking without any confirmation

Describe alternatives you've considered

(Write your answer here.)

Additional context

(Write your answer here.)

Requirement/Document

(Share it here.)


House rules

CAL-3914

GeorgeShao commented 1 month ago

I ran into this earlier today as well, not sure if it's a bug or expected functionality. Either way, I'd prefer that there be an option whether to run the business logic (creating meeting link, creating calendar event, sending confirmation email, etc) or not.

In general, it would be nice to be able to enable/disable all calendar event creation & meeting link creation, for more control.

Shaik-Sirajuddin commented 1 month ago

It would be nice to have separate endpoints to confirm , reschedule booking that trigger business logic @PeerRich Could you confirm separate endpoints should be built for this