calcom / cal.com

Scheduling infrastructure for absolutely everyone.
https://cal.com
Other
31.13k stars 7.48k forks source link

Incorrect recognition of phone number #15931

Open hunterwilhelm opened 1 month ago

hunterwilhelm commented 1 month ago

Update:

There was a commit that changed how this component works, but it doesn't fix this bug. It doesn't autofill country code correctly still even if it's in the browser settings with a country code, the autofill omits it on browsers such as chrome. It doesn't change much about the original post. See my most recent comment too.

Original Post:

Issue Summary

This issue is related to #7370, however, that is a self-hosted cal, this bug is on cal.com directly.

When autofilling a 480 number without a country prefix, the default country shows US, but then it switches to a different country. This is not satisfactory for my needs. If there isn't a plus on the front, it should keep the +1 and append the autofilled phone number.

Steps to Reproduce

  1. Put 4805551234 into your autofill in chrome

  2. Select that autofill

Screenshot 2024-07-26 at 11 41 50 AM
  1. Behold, a different country shows up.
Screenshot 2024-07-26 at 11 41 56 AM

Expected behavior

It should keep the +1 in front of the autofilled phone number if that phone number doesn't have a plus.

Other information

No response

Screenshots

No response

Environment

Desktop (please complete the following information)

- OS: MacOS
- Browser: Chrome
- Version: Version 126.0.6478.183 (Official Build) (arm64)
ymohit1603 commented 1 month ago

@PeerRich can you assign me this issue buddy i can try my best to fix it.

ciaranha commented 1 month ago

@ymohit1603 no need to have an issue assigned. Just open a pr and link back to this issue. Someone from the team will review when it’s ready.

ymohit1603 commented 1 month ago

@ciaranha Ok i got it man thanks.

hunterwilhelm commented 1 month ago

Possibly fixed by #15991, I'll leave this open until I can confirm the autofill part of this issue is fixed. I don't have time to test this until it gets released later. I'll come back and update this issue when that happens.

DEODENTALNICK commented 1 month ago

We're having trouble with this as well. Is there a way to set a default country code in the account settings or something? Cal.com is almost unusable right now for us. Very few people enter their country code when putting in their phone number.

hunterwilhelm commented 1 month ago

I agree with @DEODENTALNICK, the autofill isn't working correctly. As it won't fill the country code even if it's in the browser settings.

v.4.3.5-h-3a46375

Screenshot 2024-08-07 at 3 07 49 PM

Still defaults to a different country whose official languages don't even include English!

Screenshot 2024-08-07 at 3 07 58 PM

I'll probably create a pull request soon about this.

sarmadbokhari commented 1 week ago

+1 still seeing this issue. Would love to see this bug fixed.