calcom / cal.com

Scheduling infrastructure for absolutely everyone.
https://cal.com
Other
32.38k stars 7.98k forks source link

[CAL-4190] Blue box error when booking recurring event with conflict #16387

Open CarinaWolli opened 2 months ago

CarinaWolli commented 2 months ago

When loading the slots for a recurring event it doesn't consider conflicts for the second slot. So if there is a conflict with the second slots the recurring series still shows as available and when confirming the booking you'll receive the following error:

Screenshot 2024-08-28 at 10.25.19 AM.png

From SyncLinear.com | CAL-4190

giteshsarvaiya commented 2 months ago

May I know the "recurring event type" settings that this account had ? Limits specifically

How do I reproduce the error?

CarinaWolli commented 2 months ago

May I know the "recurring event type" settings that this account had ? Limits specifically

How do I reproduce the error?

I think this error always happens when any of the recurring slots conflicts with availability. We only check for availability for the first two slots, after that we still allow the booking to go through. So in my case, the third slot had a busy time

CarinaWolli commented 2 months ago

Can't reproduce it on the third booking any more but still getting the error when there is a conflict on the second booking

giteshsarvaiya commented 2 months ago

Okay, I will go through it

CarinaWolli commented 2 months ago

according to @emrysal this is the current expected behaviour. I thought we did load the slots with considering the first two slots availability

giteshsarvaiya commented 2 months ago

Ahh okay, you mean to say the issue is resolved ?

CarinaWolli commented 2 months ago

Can't reproduce it on the third booking any more but still getting the error when there is a conflict on the second booking

Updated the issue, looks like this is a regression