search

calcom / cal.com

Scheduling infrastructure for absolutely everyone.
https://cal.com
Other
31.51k stars 7.63k forks source link

[CAL-533] fix ButtonGroup border-radius on hover #5872

Closed PeerRich closed 1 year ago

PeerRich commented 1 year ago 
    i think we should fix this on a component level for ButtonGroup, otherwise we need to hotfix this everytime we use ButtonGroup @sean-brydon @JeroenReumkens

Originally posted by @PeerRich in https://github.com/calcom/cal.com/issues/5828#issuecomment-1337799251

CAL-533

Udit-takkar commented 1 year ago

Related: https://github.com/calcom/cal.com/issues/5800#issuecomment-1337630123

mocherfaoui commented 1 year ago

@Udit-takkar I think I know why the button hover behaves like that. The tooltip is the issue here, if you inspect the ButtonGroup div you'll see a new div injected after the last button and by using that tailwind selector the last button loses the styling. the fix I thought of is to use the Tooltip.Portal what do you think of this solution?

Udit-takkar commented 1 year ago

@mocherfaoui yeah i noticed the same after i removed the tooltip prop from Button and thanks for suggesting Tooltip.Portal.