calcom / cal.com

Scheduling infrastructure for absolutely everyone.
https://cal.com
Other
31.77k stars 7.75k forks source link

[CAL-1127] [CAL-192] "&" symbol and apostrophes don't get rendered properly in the confirmation email title #7255

Closed milospuac closed 1 year ago

milospuac commented 1 year ago

This is the name of the event type

Screenshot 2022-10-19 at 17.27.54.png

And this is how it appears in the email

Screenshot 2022-10-19 at 17.29.45.png

From SyncLinear.com | CAL-192

From SyncLinear.com | CAL-192

milospuac commented 1 year ago

Screenshot 2022-11-03 at 1.33.47 PM.png

okay so this bug is only on production ( app.cal.com) and not in development. will have to investigate more

milospuac commented 1 year ago

Can you try chrome or safari?

milospuac commented 1 year ago

brave browser

milospuac commented 1 year ago

@Udit-takkar do you use chrome?

milospuac commented 1 year ago

perplexed-mystery.gif

milospuac commented 1 year ago

Screenshot 2022-10-26 at 10.06.04 PM.png

It's also working fine here

milospuac commented 1 year ago

Also, check the bookings tab once you confirmed the meeting

Screenshot 2022-10-26 at 18.32.52.png

milospuac commented 1 year ago

okay maybe this problem is only in confirmed email

milospuac commented 1 year ago

Screenshot 2022-10-26 at 9.59.52 PM.png

I have also tested on browser

milospuac commented 1 year ago

Hey @Udit-takkar it's both gmail and outlook

Gmail:

Screenshot 2022-10-26 at 18.01.31.png

Outlook:

Screenshot 2022-10-26 at 18.00.18.png

I do have to mention that this is in the browser, don't know how it behaves in apps for those platforms.

milospuac commented 1 year ago

i have tested on gmail, outlook

milospuac commented 1 year ago

Screenshot 2022-10-26 at 5.29.55 PM.png

i am unable to reproduce this bug. what email provider are you using ?

ciaranha commented 1 year ago

@Udit-takkar did you get anywhere with this? This is still an issue for me but with forward slash/

CleanShot 2023-02-21 at 15 40 19@2x

You can book here to test if you need to: https://cal.com/ciaran/design

Udit-takkar commented 1 year ago

@Jaibles yeah it's still pending. just busy with few other things will work on this as soon as i can

G3root commented 1 year ago

same as #1961 , #6798 and #3250. for the #3250 i sent a PR , looks like this problem isn't fixed . maybe it's something to do with sendgrid 🤔 ?

PeerRich commented 1 year ago

very weird

PeerRich commented 1 year ago

@leog maybe you have an idea?

PeerRich commented 1 year ago

or @CarinaWolli

leog commented 1 year ago

@leog maybe you have an idea?

I will need to have a deeper look when I get back on Monday, but take a look at this @Udit-takkar: https://stackoverflow.com/a/53487408/1644038

CarinaWolli commented 1 year ago

maybe it's something to do with SendGrid 🤔 ?

I don't think it has anything to do with SendGrid, I just set up SendGrid locally and everything is still working.

Some findings I had:

Anybody any idea why?

leog commented 1 year ago

Anybody any idea why?

@CarinaWolli Different db encodings perhaps?

G3root commented 1 year ago

@CarinaWolli does wrapping email subject with decodeURIComponent fix this ?

CarinaWolli commented 1 year ago

@CarinaWolli does wrapping email subject with decodeURIComponent fix this ?

@G3root No it doesn't

Another thing I found: If you use your own custom event name (advanced settings - Event name in calendar ) then the special characters are also working fine. So I think the issue is because of this translation: Screenshot 2023-02-23 at 10 53 14

i18next escapes values, see here: https://www.i18next.com/translation-function/interpolation#unescape No idea though, why this is not happening locally

G3root commented 1 year ago

fixed by #7591