search

calipho-sib / sequence-viewer

neXtProt protein sequence viewer (javascript) - From SIB CALIPHO group; neXtProt project
https://cdn.rawgit.com/calipho-sib/sequence-viewer/master/examples/index.html
50 stars 18 forks source link

Fully remove Handlebars dependency? #12

Open jogoodma opened 7 years ago

jogoodma commented 7 years ago

If handlebars is no longer needed, which it appears to not be, can it be fully removed from the package?

It still lives in several places. https://github.com/calipho-sib/sequence-viewer/search?q=handlebars&utf8=%E2%9C%93

It is causing downstream build issues for react-sequence-viewer.

thinkocapo commented 6 years ago

trying to use this as a <script> in front end and its giving error about fs (Node) module not found in the Handlebars code. Any ideas? I npm install`d this module today. Different version I can use that doesn't have any handlebars in it? @jogoodma

Update

I somehow got around it. Works now but I have unrelated problem - angular ngbootstrap modal won't find this element by id="sequence-viewer however it works off my home page.

jogoodma commented 6 years ago

You can use my fork of this project https://github.com/FlyBase/sequence-viewer/tree/master. I'm keeping it around until they merge in my PR. I also just updated it with their master branch so it should be current.

The bundle file for your script tag is here.

I'm afraid that I don't have much experience with angular so I can't offer any advice here.

tarcisio-melo-sp commented 1 year ago

I'm having trouble with Handlebar, this dependency is trying to use fs module and it can't be resolved in my react app.