calipho-sib / sequence-viewer

neXtProt protein sequence viewer (javascript) - From SIB CALIPHO group; neXtProt project
https://cdn.rawgit.com/calipho-sib/sequence-viewer/master/examples/index.html
50 stars 17 forks source link

Moving style to css #21

Open manulera opened 4 years ago

manulera commented 4 years ago

Hello,

First of all, I would like to thank you for the great work. I really like the library. I think it gives a great base tool to work with sequences. I am planning to use this on a website that I am building, and I am wondering whether it would be ok for you to move the style elements to css. For example .coverage() would set the class of the <span> elements of the sequence, rather than setting the style directly. I think this has many advantages:

If I progress with the website, I would be willing to do this myself, but I wonder if this is something you find valuable and would be willing to incorporate into the project.

Once again, thanks for the fantastic library.

Best, Manu

MatSchaeff commented 4 years ago

Hello Manu, I agree, it might be better to put the style in a separate file. It would allow more customization and avoid css conflicts. I won't have time to modify it myself, but if you manage to do it, i suggest you to do a pull request, i would gladly accept it. Thank you for your suggestion, Mathieu