calipho-sib / sequence-viewer

neXtProt protein sequence viewer (javascript) - From SIB CALIPHO group; neXtProt project
https://cdn.rawgit.com/calipho-sib/sequence-viewer/master/examples/index.html
50 stars 18 forks source link

Coverage render bug for large sequences on single selection #4

Closed bpollakw closed 8 years ago

bpollakw commented 8 years ago

Hi I'm re-opening this issue (sorry for taking so much time to check it throughly) because I think now there is a problem when you do coverage using single selection for large sequences...

JS code in codepen for http://biojs.io/d/sequence-viewer example:

// Classic display of the sequence

var Sequence = require("sequence-viewer"); var seq1 = new Sequence('MALWMRLLPLLALLALWGPDPAAAFVNQHLCGSHLVEALYLVCGERGFFYTPKTRREAEDLQVGQVELGGGPGAGSLQPLALEGSLQKRGIVEQCCTSICSLYQLENYCNMALWMRLLPLLALLALWGPDPAAAFVNQHLCGSHLVEALYLVCGERGFFYTPKTRREAEDLQVGQVELGGGPGAGSLQPLALEGSLQKRGIVEQCCTSICSLYQLENYCNMALWMRLLPLLALLALWGPDPAAAFVNQHLCGSHLVEALYLVCGERGFFYTPKTRREAEDLQVGQVELGGGPGAGSLQPLALEGSLQKRGIVEQCCTSICSLYQLENYCNMALWMRLLPLLALLALWGPDPAAAFVNQHLCGSHLVEALYLVCGERGFFYTPKTRREAEDLQVGQVELGGGPGAGSLQPLALEGSLQKRGIVEQCCTSICSLYQLENYCNMALWMRLLPLLALLALWGPDPAAAFVNQHLCGSHLVEALYLVCGERGFFYTPKTRREAEDLQVGQVELGGGPGAGSLQPLALEGSLQKRGIVEQCCTSICSLYQLENYCNMALWMRLLPLLALLALWGPDPAAAFVNQHLCGSHLVEALYLVCGERGFFYTPKTRREAEDLQVGQVELGGGPGAGSLQPLALEGSLQKRGIVEQCCTSICSLYQLENYCNMALWMRLLPLLALLALWGPDPAAAFVNQHLCGSHLVEALYLVCGERGFFYTPKTRREAEDLQVGQVELGGGPGAGSLQPLALEGSLQKRGIVEQCCTSICSLYQLENYCNMALWMRLLPLLALLALWGPDPAAAFVNQHLCGSHLVEALYLVCGERGFFYTPKTRREAEDLQVGQVELGGGPGAGSLQPLALEGSLQKRGIVEQCCTSICSLYQLENYCNMALWMRLLPLLALLALWGPDPAAAFVNQHLCGSHLVEALYLVCGERGFFYTPKTRREAEDLQVGQVELGGGPGAGSLQPLALEGSLQKRGIVEQCCTSICSLYQLENYCNMALWMRLLPLLALLALWGPDPAAAFVNQHLCGSHLVEALYLVCGERGFFYTPKTRREAEDLQVGQVELGGGPGAGSLQPLALEGSLQKRGIVEQCCTSICSLYQLENYCNMALWMRLLPLLALLALWGPDPAAAFVNQHLCGSHLVEALYLVCGERGFFYTPKTRREAEDLQVGQVELGGGPGAGSLQPLALEGSLQKRGIVEQCCTSICSLYQLENYCNMALWMRLLPLLALLALWGPDPAAAFVNQHLCGSHLVEALYLVCGERGFFYTPKTRREAEDLQVGQVELGGGPGAGSLQPLALEGSLQKRGIVEQCCTSICSLYQLENYCNMALWMRLLPLLALLALWGPDPAAAFVNQHLCGSHLVEALYLVCGERGFFYTPKTRREAEDLQVGQVELGGGPGAGSLQPLALEGSLQKRGIVEQCCTSICSLYQLENYCNMALWMRLLPLLALLALWGPDPAAAFVNQHLCGSHLVEALYLVCGERGFFYTPKTRREAEDLQVGQVELGGGPGAGSLQPLALEGSLQKRGIVEQCCTSICSLYQLENYCNMALWMRLLPLLALLALWGPDPAAAFVNQHLCGSHLVEALYLVCGERGFFYTPKTRREAEDLQVGQVELGGGPGAGSLQPLALEGSLQKRGIVEQCCTSICSLYQLENYCN'); // You can add some rendering options seq1.render('#seqView1', { 'showLineNumbers': true, 'wrapAminoAcids': true, 'charsPerLine': 60, 'toolbar': true, 'search': true, 'title': "Protein Sequence" });

//Coverage list var exempleSequenceCoverage = [ {start: 0, end: 25, color: "black", underscore: false} ]; seq1.coverage(exempleSequenceCoverage); // for coverage + highlight : // seq.coverage(exempleSequenceCoverage, start, end, highlightColor);

//Define Legend and color codes var exempleLegend = [ {name: "Mature Protein", color: "#ff0000", underscore: false}, {name: "Proteotypic peptide", color: "#69CC33", underscore: false}, {name: "Synthetic peptide",color: "#fff",underscore: true} ]; seq1.addLegend(exempleLegend);

seq1.onMouseSelection(function(elem){ console.log(elem.detail); } ); seq1.onSubpartSelected(function(elem){ console.log(elem.detail); } ); seq1.onAll(function(name,data){ console.log(arguments); });

MatSchaeff commented 8 years ago

Hello Bernardo,

My bad, I missed an exception in my previous release. Thank you for the notice ! It's fixed ;)

Cheers,

Mathieu

bpollakw commented 8 years ago

Thanks Mathieu! It works perfectly!

Cheers, Bernardo