Closed piotr-gawron closed 8 years ago
Hello Piotr,
That looks great !! :+1: I will check & merge all of that in the next few days ;)
Cheers, Mathieu
Hi Mathieu,
It's nothing complicated, but I thought that you might include it in your code. If you have any questions feel free to ask. Btw. can you explain me what should I do to fix this travis CI failure? I understand it's due to the tests that I added, but I never run them with travis, so I have no idea what is missing (I ran test using "npm test" command).
Best, Piotr
Hi Piotr,
I've just merged your pull request & updated the documentation :)
As for travis CI, the failure came from the fact that ".travis.yml" file was missing. This file is necessary for travis CI to work properly. The travis CI checking was maybe launched because you added "'test' :'...'" to the scripts in the package.json.
I used this opportunity to add the yml file and (from Travis) in the Readme of the project :+1:
https://travis-ci.org/calipho-sib/sequence-viewer
Thank you again for your contribution to this project !
Best, Mathieu
I modified the package to add some new features: regions defined by coverage can have
There is a snippet code for this feature: snippets/highlight.js
I also created unit tests for my code. This required additional npm packages in devDependencies:
I refactored a bit the code to throw Error when the component render function is called on invalid element (and added tests for that as well).