search

caltechads / deployfish

Manage your whole application lifecycle in Amazon AWS ECS.
http://deployfish.readthedocs.io
Other
90 stars 20 forks source link

A few simple fixes #58

Closed coredumperror closed 4 months ago

coredumperror commented 4 months ago

I originally wrote this to make it so the service restart command doesn't just silently fail if there are no running tasks. But in the process of fixing that, I realized that the reason it was being entirely silent was that the printout that said Restarted tasks for Service("<service-name>"). at the end of service restart was not being printed. This was due to the function click.style() being used where I'm fairly sure click.secho() was intended.

So I corrected two places where that substitution was happening, and also added a code path to properly inform the user if there were no tasks to restart.

cmalek commented 4 months ago

Nice catch on the click.style. Pull request looks good. I will merge.