search

camunda-consulting / showroom-customer-onboarding

LEGACY PROJECT not maintained anymore
Apache License 2.0
58 stars 54 forks source link

Simplify workers and add a working junit test #33

Closed chDame closed 2 years ago

chDame commented 2 years ago

Hi,

Please review the small simplifications and decide if it's interesting :)

nevries commented 2 years ago

I really like the direction you're heading. I'd like to ask you to adjust some things:

  1. Rebase the PR on the latest commit of c8-iteration2, in particular in the bpmn I think little things need to be adjusted.
  2. Use the Web Modeler for changing the models (reason: results of web and desktop modeler are not binary the same, wich creates unnecessary new versions whenever we deploy the very same model via code and made with Desktop Modeler and with Web Modeler).
  3. Make sure that https://github.com/camunda-consulting/showroom-customer-onboarding/blob/c8-iteration2/milestones/V5-Automated%20Version.bpmn is always aligned with https://github.com/camunda-consulting/showroom-customer-onboarding/blob/c8-iteration2/src/main/resources/static/bpmn/customer_onboarding_en.bpmn and https://github.com/camunda-consulting/showroom-customer-onboarding/blob/c8-iteration2/milestones/Risk%20Check.dmn is always aligned with https://github.com/camunda-consulting/showroom-customer-onboarding/blob/c8-iteration2/src/main/resources/static/bpmn/risk_check_en.dmn
  4. For the test case(s), you can re-use code from here: https://github.com/camunda-consulting/showroom-customer-onboarding/blob/master/src/main/java/com/camunda/demo/customeronboarding/DemoData.java to create input data
chDame commented 2 years ago
  1. Rebase the PR on the latest commit of c8-iteration2, in particular in the bpmn I think little things need to be adjusted. Branch seems up to date to me. Your last commits are there too
chDame commented 2 years ago

Hi @nevries,

Thanks for your comments! I made the required changes. Please tell me if I missed something :)

nevries commented 2 years ago

Hi @chDame , I tested it and it looks like you lost the new 'Risks' field in the user form (decideOnApplication). It is in https://github.com/camunda-consulting/showroom-customer-onboarding/blob/c8-iteration2-simplified/milestones/decideOnApplication.form though, so just make sure the process contains the very same json please.

chDame commented 2 years ago

forms are not able to handle object.attribute variables. So better to restart from scratch with less refacto

chDame commented 2 years ago

Hi Ragnar, changes were made and tested :)