canonical / github-runner-operator

github-runner-operator - charm repository.
Apache License 2.0
9 stars 20 forks source link

`spread` pkg missing on some instances #210

Open upils opened 8 months ago

upils commented 8 months ago

Bug Description

While running tests in self-hosted runner I noticed the package spread was missing on some instances.

My job failed on:

And it succeeded (I least spread was found) on ubuntu-image-agent-64-01 after a third retry on the same code.

AFAIK I never had to explicitly install spread on the runner so I thought it was installed by default.

I only notice the issue on these 2 particular instances by chance, but I guess other instances maybe affected.

To Reproduce

If possible, create a github workflow with a constraint to run specifically on one of these two instances and trying to run spread.

Environment

N/A

Relevant log output

N/A

Additional context

No response

yhaliaw commented 8 months ago

The packages installed on the self-hosted runner provided by this charm is not the same as the GitHub-provided runners.

The image size of the GitHub-provided runners are quite large. Without any additional installation, the GitHub-provided runners are using 50+GiB of disk: https://github.com/canonical/github-runner-operator/actions/runs/7691255463/job/20956277160#step:3:6

One of the planned feature is custom images where each job can specify a custom image to run on. Currently, would installing spread package as part of the workflow be fine? If not we can look at making it part of the image used by the charm.

upils commented 8 months ago

Yes, installing spread in the workflow is fine. We also even have runners dedicated to the project so this is not a big problem.