canonical / grafana-agent-operator

https://charmhub.io/grafana-agent
Apache License 2.0
4 stars 10 forks source link

remove regular expression substitution in _instance_name #100

Closed lucabello closed 5 months ago

lucabello commented 5 months ago

Enhancement Proposal

When returning the _instance_name, we currently do a regex substitution to only keep ASCII character in label values.

However, according to the docs we link to, it explicitly mentions that label values can be unicode character.

sabaini commented 5 months ago

Heya, for addtl context I believe this was introduced here in the course of fixing #60

sed-i commented 5 months ago

Yep, probably a confusion on my part. To summarize the doc: