canonical / grafana-agent-operator

This charmed operator automates the operational procedures of running Grafana Agent, an open-soruce telemetry collector.
https://charmhub.io/grafana-agent
Apache License 2.0
4 stars 8 forks source link

Make node_exporters.enable_collectors configurable #127

Open err404r opened 3 weeks ago

err404r commented 3 weeks ago

Enhancement Proposal

There are many useful exporters, which could be very useful. Currently it looks like this options is hardcoded, but this need to be changed:

Potentially we have a 3 sources for this value:

  1. Default list with basic exporter, could have different values for lxd and physical host.
  2. Relations, some charms could request to enable custom exporters for them, for example ntp charm
  3. And the last one is charm config, For things like bcache statistics and conntrrack it is hard to identify if such exporters are actually needed so manual override would be helpful

Obviously each exporter should has corresponding list of alerts, but this is something for the future. For now it would be cool to make it configurable, so we could enable collectors manually and add custom rules through cos-configurator.