search

canonical / grafana-k8s-operator

https://charmhub.io/grafana-k8s
Apache License 2.0
6 stars 22 forks source link

Do not rely on controller storage #261

Open sed-i opened 1 year ago

sed-i commented 1 year ago

Enhancement Proposal

We need to drop use_juju_for_storage=True because controller storage is deprecated.

https://github.com/canonical/grafana-k8s-operator/blob/c65b326f397b26888ee6a8a65fbdbf047f19bb5e/src/charm.py#L1312

Need to figure out how to go about dashboards and sources relations on upgrade-charm.

https://github.com/canonical/grafana-k8s-operator/blob/c65b326f397b26888ee6a8a65fbdbf047f19bb5e/lib/charms/grafana_k8s/v0/grafana_dashboard.py#L1310

https://github.com/canonical/grafana-k8s-operator/blob/c65b326f397b26888ee6a8a65fbdbf047f19bb5e/lib/charms/grafana_k8s/v0/grafana_source.py#L503-L506

lucabello commented 3 months ago

We need to find a solution for dashboard and sources; we should probably store those in a PVC, but how do we do that?

The only other alternative would be a peer relation, but (other than being a hacky solution) we would probably hit size limitations when storing all the dashboards.