canonical / grafana-k8s-operator

This charmed operator automates the operational procedures of running Grafana, an open-source visualization toolkit, on Kubernetes.
https://charmhub.io/grafana-k8s
Apache License 2.0
6 stars 23 forks source link

Charm is happily "active/idle" even when workload cannot reach any datasources #305

Open sed-i opened 4 months ago

sed-i commented 4 months ago

Enhancement Proposal

Data not appearing on the Grafana panel due to a firewall blocking ports from related datasources. This was not initially obvious because, in other deployments, the COS subnet was the same as the OpenStack management subnet, so we never ran into firewall issues. However, this time, the COS subnet was different, and it took us a while to figure this out. -- @qch2012

It could be handy if the charm blocks when the datasource URLs are not routeable/reachable. Some impl ideas:

Very similar problem to https://github.com/canonical/grafana-agent-operator/issues/57.

simskij commented 4 months ago

I'm not sure I agree that this is a charm concern. 🤔 Let's discuss it more with the team

mmkay commented 2 months ago

It's likely the same logic as we need in grafana-agent-operator, but it's not clear yet whether it's a good idea to block the Grafana charm.

lucabello commented 1 month ago

We should do this with Pebble checks.