fix broken panel in the main dashboard

canonical / grafana-k8s-operator

https://charmhub.io/grafana-k8s

Apache License 2.0

6 stars 22 forks source link

fix broken panel in the main dashboard #345

Closed lucabello closed 3 months ago

lucabello commented 3 months ago

Issue

Closes #343.

(and fixes the broken ruff usage).

Solution

Use $__rate_interval instead of $__interval.

You can see the panel now has data: Screenshot-2024-08-06_14-30

Testing Instructions

charmcraft pack
juju deploy <grafana-charm> <resources> grafana
juju deploy prometheus

juju relate grafana:metrics-endpoint prometheus
juju relate grafana:grafana-source prometheus

Open some pages in Grafana, wait for a few scrapes, then look at the dashboard :)

lucabello commented 3 months ago

The charm now packs; integration tests need to be re-run until they pass 🫠

lucabello commented 3 months ago

Note that I'm disabling the oauth test because they started failing on timeout with no reason (they passed on main and this PR only touched a dashboard file).