Closed edlerd closed 8 months ago
Attention: 21 lines
in your changes are missing coverage. Please review.
Comparison is base (
0f7031f
) 76.55% compared to head (88bb621
) 75.60%. Report is 118 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
it is quite a lot of code in just one commit, any chance to split it into smaller ones?
It's not that many code changes, most of the lines are due to dependency updates in package-lock.json, which are a prerequisite for other changes. So factoring them out into individual PRs is painful, because they would rely on each other.
Edit: I changed the structure of the PR, keeping the changes, but breaking them into a bit smaller commits.
@edlerd looks good to me afaict, what is the policy for frontend tests?how do we catch broken UI?
Looks good. MFA options obviously missing but I assume this is out of scope at this stage