Closed pmatulis closed 6 months ago
@pmatulis I see your point and thought about that, too. However, I have two concerns about such a move:
Currently, we make the same assumptions about other package managers (e.g. snap
). While npm
may not be as ubiquitous, it's roughly in the same semantic category: we provide commands to install specific tools, but assume their respective origins (snap
, npm
) are available.
Almost notoriously, npm
can be installed in a variety of ways, and we shouldn't force a specific choice on the user if there's a chance of their having a preference here.
Perhaps this is a documentation fail then. We should specify requirements in the README.
Good point, I'll add a note.
The accessibility check is applied via the
pa11y
make target:This calls the
pa11y-install
make target:This assumes the
npm
package manager is available on the host system and will report an error if it is not:The software should first conduct a check for the presence of
npm
and, if not found, bail with a user-friendly message. The user needs to do: