Open ru-fu opened 5 months ago
make install could either check if the venv actually exists
issue: Make already checks if venv
exists, but interestingly the venv
directory will be created even if the python*-venv
dependency is missing and therefore does nothing on a subsequent run. The directory is not even empty, so there is no easy check to determine if venv
is corrupted (to my knowledge) :/
or we could say that if make install is run explicitly, it should always run, even if there is an installation already.
issue: Always running clean
would be pretty resource intensive, because it would also always be executed for make run
, make html
, make epub
, etc., and therefore increases time spent on during the iteration cycle. I think it can also be considered an anti-pattern to the declarative Make paradigm.
thought: Maybe we could use the special target .DELETE_ON_ERROR
for the install
target. See: https://www.gnu.org/software/make/manual/html_node/Special-Targets.html
note: I will do some testing and report back.
If
make install
fails and you fix the reason for the failure and run it again, it says there's nothing to do:So you need to run
make clean
first.Not sure what is the best way around this -
make install
could either check if the venv actually exists, or we could say that ifmake install
is run explicitly, it should always run, even if there is an installation already.