canonical / sphinx-docs-starter-pack

A documentation starter-pack
https://canonical-starter-pack.readthedocs-hosted.com/
10 stars 30 forks source link

`init.sh` leaves empty workflows directory #235

Closed ru-fu closed 1 month ago

ru-fu commented 1 month ago

When using the init.sh script to set up the starter pack in a subdirectory, the script moves the .github/workflows/automatic-doc-checks.yml file into the correct location as expected, but leaves an empty <docfolder>/.github/workflows directory. This directory should be removed.

rapo7 commented 1 month ago

Hello @ru-fu 👋,

This is my first time contributing to a repo which is not created by me.

The change is pretty simple.

I have added

rm -rf ".github" 

to init.sh so that it removes .github in the parent directory once the mv command is done

ru-fu commented 1 month ago

Thanks @rapo7 ! I had a look and added a comment. :)