search

canonical / sphinx-docs-starter-pack

A documentation starter-pack
https://canonical-starter-pack.readthedocs-hosted.com/
10 stars 30 forks source link

restyle 'Give feedback' button #249

Open akcano opened 4 weeks ago

akcano commented 4 weeks ago

With some refactoring, let's address this issue again. Current implementation varies the display style by screen size, preserving older behaviour (floating button) on smaller devices.

This addresses canonical/sphinx-docs-starter-pack#63.

s-makin commented 4 weeks ago

It seems to work okay, so not blocking this from going in - but I still think this should be discussed with UX. Their feedback was that having the button on the page makes more sense.

This is true, but the problem currently with it being on the page is that it forces the documentation header to split over two lines. If we want to keep it on the page, we'll have to find a way to show the page header on the next line (after all the buttons) so that it can be shown on a single line (at least in the desktop view)

akcano commented 4 weeks ago

I suggest merging this later today and addressing the outstanding aspects of the update subsequently.

ru-fu commented 4 weeks ago

As I said, I won't block this - so if you think it's an improvement, get it in.

But I think it's kinda misleading to talk about "outstanding aspects" here, since this PR changes the UX and we're leaving the discussion with UX about what the change should be for later. This should have been the first thing to do for this issue.

akcano commented 4 weeks ago

@ru-fu Hint taken; I'll add it to the liaison meeting agenda.