Adds filters for test executions

canonical / test_observer

Flutter based dashboard for visualising SRU regression test results

2 stars 3 forks source link

Adds filters for test executions #138

Closed omar-selo closed 7 months ago

omar-selo commented 7 months ago

First PR towards RTW-244.

Changes:

Adds side filters in artefact page that enable the user to filter test executions by status and review status.
Refactor artefacts filters logic to be able to common code/logic for test executions too (DRY).

Video: Screencast from 2024-03-06 16-42-42.webm

andrejvelichkovski commented 7 months ago

Just curious, do you think it will be better if we also put the button to hide/show the filters here as well, similar to how we do it on the main page for filtering artefacts?

omar-selo commented 7 months ago

Just curious, do you think it will be better if we also put the button to hide/show the filters here as well, similar to how we do it on the main page for filtering artefacts?

I opted to not put a button here since there is so much space. Unlike the dashboard that has 4 columns already. This page has no problem fitting things horizontally even on smaller screens.

andrejvelichkovski commented 7 months ago

Just curious, do you think it will be better if we also put the button to hide/show the filters here as well, similar to how we do it on the main page for filtering artefacts?

I opted to not put a button here since there is so much space. Unlike the dashboard that has 4 columns already. This page has no problem fitting things horizontally even on smaller screens.

That makes sense! Thanks for clarifying it