search

canonical / test_observer

Flutter based dashboard for visualising SRU regression test results
2 stars 2 forks source link

Apply search and filters on pressing enter #148

Closed omar-selo closed 3 months ago

omar-selo commented 3 months ago

Resolves #146

Basically, when a user is focused on a search bar and clicks enter, then the search query and filters selected are applied immediately.

omar-selo commented 3 months ago

maybe we can make the Test Execution review pop over submit and close when enter is pressed as well

Right now if we press enter a new line is inserted. That sort of makes sense cause the comment can be multi-line. Not sure if changing it to submit would be better.

andrejvelichkovski commented 3 months ago

maybe we can make the Test Execution review pop over submit and close when enter is pressed as well

Right now if we press enter a new line is inserted. That sort of makes sense cause the comment can be multi-line. Not sure if changing it to submit would be better.

Oh, I forgot the input box can be multi-line. I think it makes more sense to keep it that way, otherwise we might end up submitting the review while the reviewer still wants to add some comments.