search

cap-md089 / evmplus-v6

The source code for the Event Manager+ suite of tools for Civil Air Patrol units
GNU General Public License v2.0
7 stars 4 forks source link

Email send does not function for merged prospective member accounts #216

Closed grioux-neo closed 2 years ago

grioux-neo commented 2 years ago

Describe the bug Not one of the linked prospective member accounts will successfully send a user account login request email. This is causing issues for newer members whose account was established through the prospective member function.

To Reproduce Steps to reproduce the behavior:

  1. Go to sign in page
  2. Click on request username
  3. Enter CAPID of any linked prospective member
  4. Check capstmarys email, no email received
  5. Repeat process for NHQMember and see email received

Expected behavior A username notification email should be sent to all members who request it, prospective, NHQ, or linked prospective/NHQ.

Actual behavior Any prospective member account is unable to send a username request email

grioux-neo commented 2 years ago

I believe the issue is with the upgrade prospective member functionality. Request username function is only for NHQ accounts but the upgrade prospective member function does not create a NHQ account record, it only changes the prospective member account record, therefore there is no NHQ record to act upon for a username request activity.