caprover / one-click-apps

Community Maintained One Click Apps (https://github.com/caprover/caprover)
Apache License 2.0
557 stars 544 forks source link

Rework Bad Tags: Sonarr/Radarr/etc. & Download Clients for hardlinks ++ Drop unsupported gchr.io #573

Open bakerboy448 opened 2 years ago

bakerboy448 commented 2 years ago

General:

githubsaturn commented 2 years ago

One click apps are generally community maintained. Feel free to test the most recent version and open a PR.

tags should not be hardcoded to random versions; but rather latest or the otherwise most stable tagged branch should be used (i.e. if no latest, but has develop then use develop)

No. Tags are intentionally locked to a particular version to avoid breaking changes. Contributors are expected to test the tag that they are pushing to this repository to make sure it works. Future versions might have different requirements and might break the build.

bakerboy448 commented 2 years ago

all latest versions of the *arrs are stable and have been stable for many months, but if ya'll wish to not maintain the apps - relying on the community to - and publish versions that are explicitly end of life (i.e. sonarr's preview tag) and not supported or containers that no longer are updated as the build pipieline changed so be it I guess

Future versions might have different requirements and might break the build.

this doesn't make sense at all - how can a new container of automation apps or download clients break the build?

docker containers - by definition - keep all requirements and dependencies within themselves

githubsaturn commented 2 years ago

this doesn't make sense at all - how can a new container of automation apps or download clients break the build?

A future version might require a new env var.

One click app repository is fully extensible. You don't need to rely on this repository. If you're confident that your usage of latest won't break the functionality, you're more than welcome to spin up your own collection of one click apps, the process is extremely straightforward and many folks are already using this: https://github.com/caprover/one-click-apps#build-your-own-one-click-app-repository