caprover / one-click-apps

Community Maintained One Click Apps (https://github.com/caprover/caprover)
Apache License 2.0
544 stars 534 forks source link

App issue: Strapi - default MongoDB is not supported #787

Open nativeit opened 1 year ago

nativeit commented 1 year ago

Strapi was recently updated with commit bd28102 to replace the original deprecated Docker image with the newer v4-compatible image naskio/strapi:4.3.2.

When deployed using default settings the container fails because MongoDB is being used for the default database, but the new Strapi image requires one of sqlite or postgres or mysql.

I have modified the app template to use Strapi v4 and MySQL, and will submit that version as soon as I finish testing. The broken database may not be the only issue with naskio/strapi that needs to be sorted out, so I have also added a comment to the last Strapi PR #697 to discuss this further.

nativeit commented 4 months ago

This is growing moss at this point, but the issue remains and is still confounding users, see the related open issue in the main Caprover repo.


The root problem is that with Strapi v4, they stopped publishing official pre-compiled Docker containers (details at this link), and so there are no official images for the templates to use for Caprover's One Click Apps, rather one must build a custom Docker image, or use non-official images from Docker Hub, such as the aforementioned naskio/strapi.

I don't know how comfortable folks are with including non-official images, which may not be kept updated, and may not have immediately identifiable sources with which to verify their consistency/security. I understand that not all OCA's utilize official Docker Hub images, but I personally think that the official Caprover OCA repo is better served by avoiding such workarounds whenever possible, but I am happy to support whatever the community thinks is best.

I have successfully deployed v4 using a modified template that swaps MongoDB with MySQL, and I will check back to see if the same Docker image has been kept updated in the months [years, really] since I first identified this as an issue.

nativeit commented 4 months ago

naskio/strapi appears to be actively maintained, with recent updates last week, and the latest official version (v4.24.1) being available. I will look at the details for this non-official image, and if its source is maintained as a public repo that can be monitored and verified as consistent with the official Strapi releases, I will submit a PR to replace the old Strapi v3 templates with updated versions that use compatible databases.