caracal-pipeline / caracal

Containerized Automated Radio Astronomy Calibration (CARACal) pipeline
GNU General Public License v2.0
27 stars 6 forks source link

Option for using external mask to image the secondary calibrator #1370

Closed Sinah-astro closed 2 years ago

Sinah-astro commented 3 years ago

Is there a way to use an external mask for imaging the secondary calibrator in caracal or would imaging it with wsclean outside caracal be the way to go? I'm not happy with the model I'm getting through auto masking (in 1GC) as it includes artefacts around the calibrator. I attach the config file and log file for reference test254.txt log-caracal.txt

bennahugo commented 3 years ago

It does not look like there is from the documentation. It will be a useful feature to have, so could you add the parameter and open a pull request?

On Sun, Sep 19, 2021 at 11:25 AM Sinah-astro @.***> wrote:

Is there a way to use an external mask for imaging the secondary calibrator in caracal or would imaging it with wsclean outside caracal be the way to go? I'm not happy with the model I'm getting through auto masking as it includes artefacts around the calibrator. I attach the config file and log file for reference test254.txt https://github.com/caracal-pipeline/caracal/files/7191655/test254.txt log-caracal.txt https://github.com/caracal-pipeline/caracal/files/7191656/log-caracal.txt

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/caracal-pipeline/caracal/issues/1370, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4RE6W47PBGRXGM35ZQMZ3UCWT7PANCNFSM5EKEOAIA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--

Benjamin Hugo

PhD. student, Centre for Radio Astronomy Techniques and Technologies Department of Physics and Electronics Rhodes University

Junior software developer Radio Astronomy Research Group South African Radio Astronomy Observatory Black River Business Park Observatory Cape Town

Sinah-astro commented 3 years ago

could you add the parameter and open a pull request?

I just tried to do that but I don't know how to go about doing this. I'd appreciate some guidance.

In the meantime, given that the order in my config file is order: KGAIKGF, will it make sense to first run crosscal with order: KGA, image the secondary calibrator with masked wsclean, inspect the products, then go back to run order: KGF?

bennahugo commented 3 years ago

Add another string parameter into the schema: Say underneath https://github.com/caracal-pipeline/caracal/blob/master/caracal/schema/crosscal_schema.yml#L334 just call it external_fits_mask Then add a key to the dictionary at https://github.com/caracal-pipeline/caracal/blob/master/caracal/workers/crosscal_worker.py#L298 along lines of:

'fits-mask': config[ftype]["image"]['external_fits_mask'] + ("-%s-field%d" % (ftype, fid))

if you need a multiple iterations (typical make it a list).

I assume you are referring to the order on your secondary here? this should be KGAIKFIKFIKF for as many rounds it take to get a decent model for the secondary - again follow the same strategy going down in solution interval as your model improves and then set the interval for the final K and F to inf.