Hardcoded scan selection in crosscal must go

[paoloserra]

@bennahugo @SpheMakh https://github.com/caracal-pipeline/caracal/pull/1393 has hardcoded a scan selection into the crosscal worker. See https://github.com/caracal-pipeline/caracal/blob/9a6542e0b10aca29fbe8f5992b7dbe5df852352d/caracal/schema/crosscal_schema.yml#L159-L163 and https://github.com/caracal-pipeline/caracal/blob/9a6542e0b10aca29fbe8f5992b7dbe5df852352d/caracal/schema/crosscal_schema.yml#L273-L277

That needs to go. The default needs to be all scans.

[bennahugo]

Sorry I didn't realise example meant default... Perhaps this should be renamed.

On Mon, 13 Dec 2021, 14:59 Sphesihle Makhathini, @.***> wrote:

Closed #1396 https://github.com/caracal-pipeline/caracal/issues/1396 via #1397 https://github.com/caracal-pipeline/caracal/pull/1397.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/caracal-pipeline/caracal/issues/1396#event-5756683407, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4RE6USCTX6VOE66OTWWUTUQXU2NANCNFSM5J5YY6LA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[paoloserra]

No worries @bennahugo , I thought that was the problem indeed.

We adopted example as he key to give the default value a long time ago. Back then, there were only a few keys that were allowed to be used, and example was the only one that made some kind of sense. Default or something like that was not allowed.

We haven't looked into that since then -- maybe that's changed now.