Closed Athanaseus closed 1 year ago
retest this please
Just a note there is definitely breakage in newer Regions parsing. Regions files that read fine with DS9 fail to open due to some coordinate system specification issues in the comment lines. I tried this fix for cubical itself, but I've decided to downgrade and revert to previous versions, see https://github.com/ratt-ru/CubiCal/pull/465
Just a note there is definitely breakage in newer Regions parsing. Regions files that read fine with DS9 fail to open due to some coordinate system specification issues in the comment lines. I tried this fix for cubical itself, but I've decided to downgrade and revert to previous versions, see ratt-ru/CubiCal#465
Bleh, maybe it's time to redesign this worker from scratch..
I've just spotted there is an issue in crystalball as well due to this. Will submit a downgrade PR now
Just a note there is definitely breakage in newer Regions parsing. Regions files that read fine with DS9 fail to open due to some coordinate system specification issues in the comment lines. I tried this fix for cubical itself, but I've decided to downgrade and revert to previous versions, see ratt-ru/CubiCal#465
Bleh, maybe it's time to redesign this worker from scratch..
I still think regions files are the way to go -- they are certainly much easier to work with than casa latices. We just need to be careful with the regions parsers we use
Thanks @bennahugo, then it makes sense to roll this back and just pin it to the previous version of regions
.
Also, I notice that the latest regions require python>=3.8
. .ie. users running lower versions of python
will get previous versions of regions
.
Do not merge (see comments by @bennahugo and @Athanaseus above).
@Athanaseus , please update the branch and then it should be good to go.
Athanaseus dismissed KshitijT’s stale review via b150526 1 hour ago.
😢
@Athanaseus please merge when ready.
resolves #1438 resolves #1429