caracal-pipeline / caracal

Containerized Automated Radio Astronomy Calibration (CARACal) pipeline
GNU General Public License v2.0
28 stars 6 forks source link

User clean mask bug in line worker for multi-target MS #1589

Closed paoloserra closed 1 day ago

paoloserra commented 2 weeks ago

In the line worker users can provide a clean mask. CARACal will check whether the mask needs to be regridded spatially and/or spectrally before using it for cleaning. To do so, CARACal needs to read in the RA,Dec of the target (among other things). This procedure is faulty for input MS's with multiple targets. CARACal takes for all targets the RA,Dec of the last target. Note that CARACal will not crash, because WSClean only checks for the consistency between the cube's and the mask's size, not the WCS grid. Therefore, CARACal will happily continue with a mask which, however, has been regridded in the wrong way -- and so cleaning will happen at the wrong place within the cube.