caracal-pipeline / caracal

Containerized Automated Radio Astronomy Calibration (CARACal) pipeline
GNU General Public License v2.0
28 stars 6 forks source link

"auto" selection falling over #813

Closed o-smirnov closed 4 years ago

o-smirnov commented 4 years ago

So this MS is dead simple:

![Uploading image.png…]()

However, running it with auto for the various calibrators in observation_config results in:

meerkathi - 2020-02-07 22:16:06,291 CRITICAL - Container [summary_json_0-1403251014217441581106397601745] has executed successfully
meerkathi - 2020-02-07 22:16:06,291 CRITICAL - Runtime was 0:00:38.143173.
meerkathi - 2020-02-07 22:16:06,292 CRITICAL - INFO:STIMELA-2:Saving pipeline information in .last_automatically_catergorize_observed_fields.json
meerkathi - 2020-02-07 22:16:06,293 CRITICAL - INFO:STIMELA-2:Recipe executed successfully
meerkathi - 2020-02-07 22:16:06,296 INFO - Extracting info from output-shap3/1530628393_sdp_l0-obsinfo.json and (if present, and only for the purpose of automatically setting the reference antenna) the metadata file /home/oms/projects/Shapley/1530628393_sdp_l0-obsinfo.json
meerkathi - 2020-02-07 22:16:06,535 INFO - MS has 1 spectral windows, with NCHAN=4096
meerkathi - 2020-02-07 22:16:06,535 INFO - CHAN_FREQ from 856000000.0 Hz to 1711791015.625 Hz with average channel width of 208984.375 Hz
meerkathi - 2020-02-07 22:16:07,541 ERROR - An unhandled exeption occured. If you think this is a bug please report it.
meerkathi - 2020-02-07 22:16:07,541 ERROR - Your logfile is here: /home/oms/projects/Shapley/log-meerkathi.txt.
meerkathi - 2020-02-07 22:16:07,542 ERROR - You are running version: 0.1.0-1439-g0f0c68e
meerkathi - 2020-02-07 22:16:07,542 ERROR - Traceback (most recent call last):
  File "/home/oms/projects/meerkathi/meerkathi/main.py", line 166, in __run
    pipeline.run_workers()
  File "/home/oms/projects/meerkathi/meerkathi/workers/worker_administrator.py", line 287, in run_workers
    worker.worker(self, recipe, config)
  File "/home/oms/projects/meerkathi/meerkathi/workers/observation_config_worker.py", line 193, in worker
    "section of the config file".format(conf_fields, term))
RuntimeError: Could not find field/selection ['auto']. Please check the [observation_config.target] section of the config file
o-smirnov commented 4 years ago

Selecting the fields manually seems to work. So I guess auto is broken in master. Or broken for me, anyway.

KshitijT commented 4 years ago

I think recent changes by @SpheMakh mean that 'auto' selection is no longer valid. For calibrators, you could go with 'all' or 'longest' or 'nearest' or the field name and for target you could go with the name or 'all'. Like in the MeerKAT defaults:

observation_config: 
  obsinfo: 
    enable: true
  target:
    - 'all'
  gcal: 
    - 'all'
  bpcal:
    - 'longest'
  fcal:
    - 'longest'
  xcal:
    - 'longest'
  reference_antenna: '0'
  plot_elevation_tracks: true
o-smirnov commented 4 years ago

Ah. :)

Well being the professor, I'm allowed to miss the redefinition of options...

o-smirnov commented 4 years ago

Thanks @KshitijT, it was exactly that.