search

casbloem / vue-luxon

Easy use of datetime with Luxon in Vue
https://npmjs.com/package/vue-luxon
72 stars 8 forks source link

README examples are outdated #6

Closed IlyaSemenov closed 6 years ago

IlyaSemenov commented 6 years ago

The top header example:

vue-luxon-preview

{{ '2019-01-01' | luxon('MMM, yyyy') }}

produces 1 January 2019 rather than expected Jan, 2019.

Most other examples also either don't work or crash, for example {{ luxon.format('dd-MM-YY') }} gives [Vue warn]: Failed to resolve filter: luxon.format.

After reading the source code I discovered that the correct syntax was:

{{ '2019-01-01' | luxon:format('MMM, yyyy') }}

Isn't it time to update the documentation, or at least add a warning at the top of the page that the syntax is different in the latest version?

casbloem commented 6 years ago

I've fixed the typos in the readme. And removed the img for now. Thanks for pointing it out.