Stabilize simplest possible driver

cat-in-136 / ws2812-esp32-rmt-driver

WS2812 driver using ESP32 RMT for Rust

MIT License

40 stars 21 forks source link

Stabilize simplest possible driver #13

Closed faern closed 2 years ago

faern commented 2 years ago

This is my suggestion for how to implements #12. What do you think? Sorry if I'm rushing ahead before you even commented on the issue. I just wanted to see how the API could turn out and then I felt I should share what I had tested out.

At the time of posting this PR it also contains the commits from #11. But if that PR is merged first this can be rebased.

close #12

cat-in-136 commented 2 years ago

I agree with your suggestion.

But some test cases fail on your code. Could you please check the github action result?

faern commented 2 years ago

Great. I'll look into it when I have the time. Likely not today.

faern commented 2 years ago

Fixed.

faern commented 2 years ago

I spoke too soon :sweat_smile: Now I fixed it for all features I did not test locally :P