search

cat-in-136 / ws2812-esp32-rmt-driver

WS2812 driver using ESP32 RMT for Rust
MIT License
40 stars 21 forks source link

Update for newer HAL #43

Closed DavidVentura closed 2 days ago

DavidVentura commented 4 months ago

This change depends on https://github.com/esp-rs/esp-idf-hal/pull/386 getting merged and a new version getting tagged. Alternatively, we can store t0h, t0l, t1h, t1l and create a new Symbol for each bit in the iterator; I'm not sure if Copy will be faster than creating the Symbol

Closes #42

cat-in-136 commented 4 months ago

Updated .github/workflows/rust.yml is also needed to upgrade rust version on github workflow. Your code could not are compiled even on my local using the latest rust version.

cat-in-136 commented 4 months ago

I prefer your approach since less complexity in encode_iter() function than #41. But I wonder that it is impossible to refer just Symbol variable in encode_iter(). Symbol does not seem to implement neither Copy or Clone.

DavidVentura commented 4 months ago

I linked a PR where Symbol got made Copy, but it's not released yet. This is why I used a not-yet-existent version of esp-idf-hal

mn-xd commented 2 months ago

Also solves this issue: #48