search

cat-in-136 / ws2812-esp32-rmt-driver

WS2812 driver using ESP32 RMT for Rust
MIT License
40 stars 21 forks source link

Update esp-idf-hal with workaround to copy symbol #49

Closed MnlPhlp closed 1 month ago

MnlPhlp commented 1 month ago

Similar to #43 this updates esp-idf-hal and also esp-idf-sys to the most recent version. Because the change in esp-idf-hal that makes Symbol copy is not yet published, this uses unsafe code as a workaround. The unsafe code just copies the bytes, so this should make no difference to Symbol being cloned/copy. Once a new esp-idf-hal version is out, the unsafe part can just be replaced by self.bit0 and self.bit1 again.

MnlPhlp commented 1 month ago

this should also fix #42 and #48

cat-in-136 commented 1 month ago

@MnlPhlp Thank you for your suggestion and code.

I have waited for update releases of esp-idf-sys,esp-idf-hal before merging #43. But no new versions are released... It would certainly be practical to accept your workaround.

I will commit this PR after confirming it with my device.

simonborje commented 2 weeks ago

Just FYI: A new version of esp-idf-hal was just released (0.44)