Modify helper class to use instantiated notices (#47) - Githubissues

catalyst / moodle-local_sitenotice

https://moodle.org/plugins/local_sitenotice

4 stars 7 forks source link

Modify helper class to use instantiated notices (#47) #48

Closed cameron1729 closed 2 years ago

cameron1729 commented 2 years ago

Helper class methods now require instantiated site notices (instead of an ID which is then loaded)
External functions load the class once then pass to helper methods
General phpdoc improvements and type annotations
Removed some unnecessary methods from the helper class

I did some basic profiling and was able to verify that when acknowledging a notice the total number of queries dropped by 2.

Fixes #47