search

catalystneuro / ndx-bipolar-scheme

Structure for storing the bipolar schema of a recording in an NWB file.
BSD 3-Clause "New" or "Revised" License
1 stars 2 forks source link

Fix BipolarSchemeTable #15

Closed rly closed 4 years ago

rly commented 4 years ago
  1. The column index field should be named [column_name]_index, not [column_name]_vector_index
  2. The test needs to add the table into the file somewhere. I added it as an optional group in EcephysExt
  3. I think the first docval arg for EcephysExt should be 'name'
  4. The default DynamicTableMap should work fine so I removed BipolarSchemeTableMap
  5. I did some minor code cleanup

This PR merges into the BipolarSchemeTable branch.

rly commented 4 years ago

Note: you can get around point 1 about the naming of the column index field by remapping the attribute name in BipolarSchemeTableMap

bendichter commented 4 years ago

@rly thanks so much!

@Armin12 please note these changes