search

catmaid / CATMAID

Collaborative Annotation Toolkit for Massive Amounts of Image Data
https://catmaid.org
GNU General Public License v3.0
188 stars 57 forks source link

Review widget: superfluous requests when hiding tracing overlay #1732

Open schlegelp opened 6 years ago

schlegelp commented 6 years ago

When walking along a segment in review mode using Q and W, hiding the tracing overlay by pressing Space used to suppress treenode queries. That increased speed for remote tracing by a lot and was useful for e.g. reviewing of long tracts where seeing the treenodes does not really add anything.

Since 2018.04.15., hiding the tracing overlay does not only not suppress queries to node/list but adds a query to treenodes/compact-detail. Is that working as intended?

tomka commented 6 years ago

When walking along a segment in review mode using Q and W, hiding the tracing overlay by pressing Space used to suppress treenode queries. That increased speed for remote tracing by a lot and was useful for e.g. reviewing of long tracts where seeing the treenodes does not really add anything.

Doing that seems indeed very useful. Especially when also enabling the display of reference lines (Settings Widget) and auto centering (Review Widget) you would even see exactly where the nodes are.

Since 2018.04.15., hiding the tracing overlay does not only not suppress queries to node/list but adds a query to treenodes/compact-detail. Is that working as intended?

The reason for this compact-detail request is that the active node changes and the front-end expects all information to be available for the active node. Because when pressing Space this information isn't loaded automatically (nodes are hidden), the active node information needs to be loaded separately. So yes, this is currently working as intended and not doing so before release 2018.04.15 caused active node information to be missing in some cases.

However, I realize that this extra request (even though it is fast) adds to latency in remote work and it would be best to get rid of it. I can imagine updating the Review Widget to initially load the full skeleton to be reviewed (or even just the segment under review) and just get all the needed data from this skeleton/fragment without the extra round-trip to the back-end.

schlegelp commented 6 years ago

What about suppressing node/list while holding space?

tomka commented 6 years ago

You are right, I misread your original post and didn't realize node/list wasn't suppressed for you. This is something I can reproduce in review mode and will try to provide a fix soon. Without review, node/list requests are suppressed correctly for me when Space is held down.