catmaid / CATMAID

Collaborative Annotation Toolkit for Massive Amounts of Image Data
https://catmaid.org
GNU General Public License v3.0
182 stars 56 forks source link

[BUG] Neuron Search by NOT annotation seems to exclude all neurons without any annotations #2219

Closed davidhildebrand closed 2 years ago

davidhildebrand commented 2 years ago

Short description

Using Neuron Search with a specified annotation with NOT checkbox exclusion appears to eliminate all neurons without any annotations. Perhaps this is the desired behavior, but it seems counterintuitive. Thanks to Martha Bagnall for bringing it to my attention.

More information

Neuron search for named as: 'utriculartarget' returns 682 entries.

Neuron search for named as: 'utriculartarget' annotated: 'dorsal' returns 39 entries.

Neuron search for named as: 'utriculartarget' annotated: NOT 'dorsal' returns 94 entries.

Subsequently, after adding an annotation ('utricular_target') to all neurons meeting criteria named as: 'utriculartarget' ... resulted in ... Neuron search for named as: 'utriculartarget' annotated: NOT 'dorsal' returns 638 entries.

tomka commented 2 years ago

Thanks for the bug report @davidhildebrand! I can reproduce this issue and it definitely looks more like a bug than intended behavior. I'll try to come up with a fix.

davidhildebrand commented 2 years ago

Great, @tomka. Thank you!

tomka commented 2 years ago

I pushed a fix to both the dev and master branch. The Docker images are updated as well. Please re-open the issue if this still doesn't work for you. The bug was fixed in my test case by this change.