cauldron / activity-browser

GUI for Brightway
GNU Lesser General Public License v3.0
0 stars 3 forks source link

Fix availability of plugin base class during plugin loading #37

Closed zoltanszocs closed 3 months ago

zoltanszocs commented 3 months ago

The import of the Plugin abstract class needs to be moved above the loading of the actual plugins, which happens with the import of the plugin controller. This is needed so that the plugins can use it as base class when they are loaded.

Checklist

cmutel commented 3 months ago

Weird that this is necessary but LGTM

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 10179149240

Details


Totals Coverage Status
Change from base Build 9931388601: 0.04%
Covered Lines: 8010
Relevant Lines: 14419

💛 - Coveralls
marc-vdm commented 3 months ago

FYI https://github.com/LCA-ActivityBrowser/activity-browser/commit/7b1217d8a76998360ee97df0f146bfb58d826cf0

zoltanszocs commented 3 months ago

In the end, we decided to break the direct dependency on AB in the ab-plugin-onedrive, so this PR is no longer necessary. Closing it.