cauldron / activity-browser

GUI for Brightway
GNU Lesser General Public License v3.0
0 stars 3 forks source link

First version of the property editor #42

Closed zoltanszocs closed 2 months ago

zoltanszocs commented 2 months ago

Checklist

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10509564919

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
activity_browser/logger.py 0 2 0.0%
activity_browser/layouts/tabs/activity.py 8 11 72.73%
activity_browser/actions/exchange/edge_properties.py 10 14 71.43%
activity_browser/ui/tables/models/base.py 11 15 73.33%
activity_browser/actions/activity/node_properties.py 11 16 68.75%
activity_browser/ui/tables/activity.py 14 21 66.67%
activity_browser/ui/tables/delegates/delete_button.py 6 20 30.0%
activity_browser/ui/tables/models/activity.py 17 32 53.13%
activity_browser/ui/tables/properties.py 9 43 20.93%
activity_browser/ui/widgets/property_editor.py 10 62 16.13%
<!-- Total: 130 366 35.52% -->
Files with Coverage Reduction New Missed Lines %
activity_browser/ui/tables/activity.py 1 60.75%
activity_browser/layouts/tabs/activity.py 1 83.77%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 10406012142: -0.5%
Covered Lines: 8216
Relevant Lines: 15134

💛 - Coveralls
cmutel commented 2 months ago

This is a great start!

Screenshot 2024-08-16 at 14 22 53
cmutel commented 2 months ago

@zoltanszocs Looking good, and the functionality works as expected. Please see my earlier comments on the next set of things to work on. Thanks!

cmutel commented 2 months ago
cmutel commented 2 months ago

Great; let's add a bit and then we can merge this and do the next stage.

Screenshot 2024-08-21 at 09 19 37
cmutel commented 2 months ago

We need one more big step here: If I understand correctly, we have a property editor for the current process or product being viewed, and the ability to edit the properties of the products or processes being linked to. However, we also need to be able to edit the edges (called Exchanges in the codebase). So this menu:

Screenshot 2024-08-22 at 13 34 45

Needs to have two options: "Node properties" and "Edge properties", with the code saving to either the appropriate Node object, or to the Edge.