Closed will7200 closed 2 months ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
activity_browser/ui/web/base.py | 1 | 2 | 50.0% | ||
activity_browser/application.py | 1 | 3 | 33.33% | ||
activity_browser/ui/web/tree_navigator.py | 52 | 264 | 19.7% | ||
<!-- | Total: | 56 | 271 | 20.66% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
activity_browser/application.py | 1 | 73.53% | ||
<!-- | Total: | 1 | --> |
Totals | |
---|---|
Change from base Build 10507369358: | -0.6% |
Covered Lines: | 8159 |
Relevant Lines: | 15061 |
Thanks @will7200 .Can we have a call to talk about this? Shouldn't take too long. Maybe in the next 6 hours?
@cmutel For the tag types, since they are aimed at being categorical data types, what data types do we want to support? The tags support json values so that consist of numbers, strings, arrays, and objects. Currently I implemented support for:
int
float
string
date (string underneath)
So we can drop the number ones (int and float). Do we need to support others ones? How much benefit would supporting lists and objects?
So we can drop the number ones (int and float). Do we need to support others ones? How much benefit would supporting lists and objects?
A good question - probably the schema is too loose here. I can see a good argument for int
, in some numbered classification scheme, but am struggling to see how float
would make sense (especially considering underlying floating point mechanics). I also agree that datetimes smell a bit fishy, but if converted to ISO 8601 then that seems OK.
Definitely not objects including lists or any other nonsense. Special cases aren't special enough.
@cmutel Ready for review will require https://github.com/brightway-lca/bw_graph_tools/pull/20 to be merged for tests to pass
Checklist
[x] Create new
NavigatorWidget
class for contribution tree, and make it available in this row:[x] Design decision on
tags
system. Tags are a part of our fundamental data schema, and are designed to be categorical (quantitative values would normally be aproperty
).[x] Add ability to add tags to processes, either in the existing edit interface or in a new pop-up. This interface should autocomplete against existing tag systems already in the data; we might want to cache these on the
Database
object instead of scanning the whole database when doing any initial load.[x] Implemented aggregation algorithm by
tags
system to the results. Handle missingtags
elegantly.[x] Write initial graph traversal logic in new NavigatorWidget` class
[x] Write click event handling logic in
NavigatorWidget
class[ ] User acceptance and change requests