cauldron / activity-browser

GUI for Brightway
GNU Lesser General Public License v3.0
0 stars 3 forks source link

Zoltan/defining default allocation #45

Closed zoltanszocs closed 1 month ago

zoltanszocs commented 2 months ago

Checklist

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10628628341

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
activity_browser/ui/tables/inventory.py 8 9 88.89%
activity_browser/ui/tables/delegates/combobox.py 9 19 47.37%
activity_browser/ui/tables/models/inventory.py 15 25 60.0%
<!-- Total: 33 54 61.11% -->
Files with Coverage Reduction New Missed Lines %
activity_browser/ui/tables/inventory.py 1 55.83%
activity_browser/bwutils/uncertainty.py 5 93.33%
<!-- Total: 6 -->
Totals Coverage Status
Change from base Build 10594244959: 0.003%
Covered Lines: 8244
Relevant Lines: 15181

💛 - Coveralls
cmutel commented 2 months ago

@zoltanszocs This is good progress! The double-click to change database default allocation is definitely not intuitive, but I don't think we need to worry about that right now.

I updated https://github.com/cauldron/activity-browser/issues/33 with more detail on the remaining tasks.

Database processes which have the type multifunctional cannot be dragged into calculation setups

This is blocked by https://github.com/brightway-lca/multifunctional/issues/23

Uses should be able to see if the given allocation property key is present and non-zero for each functional exchange of each multifunctional process in a database.

I don't see the allocation values, not sure where the bug is. According to the tests this information is being stored correctly?