search

cawa-93 / vite-electron-builder

Secure boilerplate for Electron app based on Vite. TypeScript + Vue/React/Angular/Svelte/Vanilla
MIT License
2.34k stars 256 forks source link

Replace npx with direct electron-builder bin on release job #953

Closed danilopolani closed 1 year ago

danilopolani commented 1 year ago

Due to this issue https://github.com/electron-userland/electron-builder/issues/6411 the build with npx when rebuilding native dependencies hangs forever. By replacing npx with the direct electron-builder bin file it works (on all platforms)

cawa-93 commented 1 year ago

Pls, add comment above with description add link to relevant issue

danilopolani commented 1 year ago

There is no open issue about this in this repo, I thought it was easier to just create the PR since the issue is in electron-builder itself. Do I really need to create a issue to fix this?

cawa-93 commented 1 year ago

I mean link to this issue - https://github.com/electron-userland/electron-builder/issues/6411

Just so that new users can quickly understand why this strange piece of code is here, and to check if the problem is still relevant.