cbrnix / Newaita

Linux icon theme
386 stars 16 forks source link

Miscolored icons in Plasma-Discover #114

Closed ripefig closed 4 years ago

ripefig commented 5 years ago

image

I would recommend making the action icons black. The system Breeze monochrome icons adjust automatically according to background. I think this way, you will not need a separate dark theme and you will avoid poor contrast icons in mixed themes (for example Yaru or dark plasma/ light app theme).

For example, this is Krunner with Newaita-light: image

demoy commented 5 years ago

It's not quite automatic, the each monochrome icon has to styled in such a way that it inherit the active colorscheme. Which is easy enough.. until you realize how many icons have to changed.. Mixed themes overall are poorly supported in KDE not just in icons. And even when they inherit the colors monochrome icons choose the wrong colors in some areas like the window bar and the KDE settings.

ripefig commented 5 years ago

Can you clarify how that works @demoy? How do the other themes achieve this exactly?

BTW: example with Yaru Kvantum (same KDE color scheme)

Newaita: image

Papirus: image

demoy commented 5 years ago

Here is an excerpt from document-open in la capitaine:

   <style type="text/css" id="current-color-scheme">
     .ColorScheme-Text {
       color:#4d4d4d;
     }
     </style>
 </defs>
   <path
      style="fill:currentColor;...unrelated stuff.."
    class="ColorScheme-Text"

Fill has to be set to currentColor, the class ColorScheme-Text sets the color for non-KDE applications. I choose La Capitaine because a year back I help to get this feature.. it was fun for the first 70+ icons but after seeing around a one hundred left I gave up and another KDE user finished them.