[Icon Requests] for Meld Application's Buttons

PJ-Singh-001 commented 4 years ago

The Meld application has three large buttons with actions: (1) File comparison (2) Directory comparison (3) Version control view

There are issues with the icons for buttons (1) and (3) above. Please see the screenshots of Meld posted at the end of this issue.

(1a) Need new larger colored icon for "File comparison" button

We are missing the 48px document-new.svg colored icon in Newaita. Because this is a large icon, the new icon must be colored, and must not be monochromatic symbolic style.

/usr/share/icons/Newaita/actions/48/document-new.svg

(1b) Need symbolic-links `filenew.svg` --> `document-new.svg`

We are also missing the filenew.svg symbolic-links. This doesn't impact Meld, but may be used by other applications.

/usr/share/icons/Newaita/actions/16/filenew.svg (should be link to document-new.svg)
/usr/share/icons/Newaita/actions/22/filenew.svg (should be link to document-new.svg)
/usr/share/icons/Newaita/actions/24/filenew.svg (should be link to document-new.svg)
/usr/share/icons/Newaita/actions/32/filenew.svg (should be link to document-new.svg)
/usr/share/icons/Newaita/actions/48/filenew.svg (should be link to document-new.svg)

(3a) Need new larger colored icon for "Version control view" button

We are also missing the 48px meld-version-control.svg colored icon in Newaita. Because this is a large icon, the new icon must be colored, and must not be monochromatic symbolic style.

/usr/share/icons/Newaita/actions/48/meld-version-control.svg

(3b) Need new monochromatic icons for `meld-version-control.svg`

We are missing the smaller meld-version-control.svg monochromatic symbolic icons in Newaita. Because these are small icons, the new icons must be must be monochromatic symbolic style.

/usr/share/icons/Newaita/actions/16/meld-version-control.svg
/usr/share/icons/Newaita/actions/22/meld-version-control.svg
/usr/share/icons/Newaita/actions/24/meld-version-control.svg
/usr/share/icons/Newaita/actions/32/meld-version-control.svg

Additional information for the "File comparison" button icon

The "File comparison" button in Meld requires a 48x48 icon for document-new.png. Unfortunately, Newaita only has monochromatic symbolic versions of this icon that are 16, 22, 24, and 32 pixels. Therefore, Meld is forced to render a smaller monochromatic icon for this button.

File comparison

Here are the smaller monochromatic icons currently available in Newaita.

/usr/share/icons/Newaita/actions/16/document-new.svg
/usr/share/icons/Newaita/actions/22/document-new.svg
/usr/share/icons/Newaita/actions/24/document-new.svg
/usr/share/icons/Newaita/actions/32/document-new.svg

However, the solution isn't to simply create a larger (48 px) version of the existing document-new.svg, because the "style" of the icon should not be monochromatic. Instead, at this size, the icon should be colored, like the folder icon used for the "Directory comparison" button (2).

Directory comparison

Note that a smaller document-new.svg is also used in Meld's toolbar. In the toolbar, the monochromatic symbolic icon looks appropriate.

Meld toolbar

Additional information for the "Version control view" button icon

The "Version control view" button in Meld requires a 48x48 icon for meld-version-control.png. Newaita is missing this icon, so the application defaults to the 48x48 icon from the hicolor theme:

Version control view

/usr/share/icons/hicolor/48x48/apps/meld-version-control.png

For icon sizes 16, 22, 24, and 32 pixels, it would be OK to add monochromatic symbolic versions of meld-version-control.svg. But for the 48 pixel version, the icon should be colored, like the folder icon used for the "Directory comparison" button (2).

Directory comparison

Screenshot of Meld using Newaita icon theme

This image shows Meld incorrectly displaying a small monochromatic icon for the "File comparison" button icon (A) using the Newaita icon theme. This image also shows Meld incorrectly displaying a large colored icon from the hicolor theme, for the "Version control view" button icon (3). The Newaita icon theme should supply the correct icons for both of these buttons.

Screenshot from 2019-09-19 21-05-08

Screenshot of Meld using Gnome icon theme

This image shows Meld displaying a large colored icon for the "File comparison" button icon (A) using the Gnome icon theme. This image also shows Meld displaying a large colored icon from the hicolor theme, for the "Version control view" button icon (3).

Screenshot from 2019-09-19 21-39-32

cbrnix commented 4 years ago

I can try putting 48 size icons in Apps so as not to destroy the system. True, I'm not sure that the software will not pick them up as default ones for use.

cbrnix commented 4 years ago

Added. It seems that it did not affect the rest of the icons

PJ-Singh-001 commented 4 years ago

Cbrnix,

Thanks. This is an unusual situation, indeed, with the Meld application using 48 pixel icons as "action" icons. I will try this out an comment back.

PJ-Singh-001 commented 4 years ago

Looks good! Thanks!

Screenshot from 2019-09-20 22-07-25

cbrnix / Newaita